Skip to content

Fix/sort initially fetched txes - LW-12194 #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mirceahasegan
Copy link
Contributor

Context

initially fetched trasactions were returned in asc order, but sliced from array start when we actually want the latest txes

Proposed Solution

Important Changes Introduced

rhyslbw
rhyslbw previously approved these changes Jan 31, 2025
AngelCastilloB
AngelCastilloB previously approved these changes Jan 31, 2025
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially fetched trasactions were returned in asc order,
but sliced from array start when we actually want the latest txes
@mirceahasegan mirceahasegan dismissed stale reviews from AngelCastilloB and rhyslbw via 72d81c0 January 31, 2025 13:17
@mirceahasegan mirceahasegan force-pushed the fix/sort-initially-fetched-txes branch from e4fe70b to 72d81c0 Compare January 31, 2025 13:17
@rhyslbw rhyslbw merged commit e3e10e2 into master Jan 31, 2025
5 of 6 checks passed
@rhyslbw rhyslbw deleted the fix/sort-initially-fetched-txes branch January 31, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants